Skip to content

TINYDOC-3565 - Fix insert and remove order for the id 2 edit in Suggested Edits demo models - #4298

Merged
kemister85 merged 1 commit into
tinymce/8from
hotfix/8/TINYDOC-3565
Jul 29, 2026
Merged

TINYDOC-3565 - Fix insert and remove order for the id 2 edit in Suggested Edits demo models#4298
kemister85 merged 1 commit into
tinymce/8from
hotfix/8/TINYDOC-3565

Conversation

@kemister85

@kemister85 kemister85 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Ticket: TINYDOC-3565

Site: Staging branch

Changes:

  • Swapped the insert and remove text runs for the "id":2 edit in the suggestededits-model attribute, so the pair reads remove then insert. Applied to all four Suggested Edits demos, whose contents arrays are identical:
  • modules/ROOT/examples/live-demos/suggestededits/index.html
  • modules/ROOT/examples/live-demos/suggestededits-auto-approve/index.html
  • modules/ROOT/examples/live-demos/suggestededits-access-read/index.html
  • modules/ROOT/examples/live-demos/suggestededits-access-feedback/index.html

What was broken

The "id":2 modification in the second paragraph listed its inserted run before its removed run. A modification tracked under a single op id is emitted as the removed run followed by the inserted run, so the demo displayed a modification in the reverse of the order the plugin produces.

What the fix does

Reorders the two runs so the review view shows the deletion followed by the insertion.

  • Reject-all (original): Try out the Suggested Edits feature by typing in the editor and then clicking the Review Changes button in the toolbar.
  • Accept-all (final): Try out the Suggested Edits feature: type in the editor, apply formatting or delete some content. Then, click the Review Changes button in the toolbar to see your changes.

The accept-all text continues to match the static HTML in each demo's textarea body.


Pre-checks:

  • Branch is correctly prefixed: hotfix/8/TINYDOC-3565
  • Build passes without console errors, warnings, or issues.

Review:

  • Documentation Team Lead has reviewed.

@kemister85
kemister85 requested a review from metricjs July 29, 2026 01:13
@kemister85
kemister85 marked this pull request as ready for review July 29, 2026 01:13
@kemister85
kemister85 requested review from a team and soritaheng as code owners July 29, 2026 01:13
@kemister85
kemister85 merged commit 0035533 into tinymce/8 Jul 29, 2026
5 checks passed
@kemister85
kemister85 deleted the hotfix/8/TINYDOC-3565 branch July 29, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants